Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused JS imports #4096

Closed
wants to merge 1 commit into from

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Oct 26, 2024

Fixes #0000

Changes proposed in this pull request:

  • Removes unused imports which were caught by temporarily adding "noUnusedLocals": true to the global flarum-tsconfig and running tsc --noEmit --emitDeclarationOnly false.

Reviewers should focus on:
It may be worth thinking about if "noUnusedLocals": true and/or "noUnusedParameters": false should become part of the official flarum-tsconfig or perhaps if that should just be used in the framework itself, without imposing it to everyone extending the baseline config. Thoughts on that?

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 26, 2024 18:21
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner October 26, 2024 18:21
@DavideIadeluca DavideIadeluca deleted the di/unused-code branch November 9, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant