Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
"noUnusedLocals": true
to the globalflarum-tsconfig
and runningtsc --noEmit --emitDeclarationOnly false
.Reviewers should focus on:
It may be worth thinking about if
"noUnusedLocals": true
and/or"noUnusedParameters": false
should become part of the officialflarum-tsconfig
or perhaps if that should just be used in the framework itself, without imposing it to everyone extending the baseline config. Thoughts on that?Screenshot
Necessity
Confirmed
composer test
).Required changes: